This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Batch Writes #252
Merged
Batch Writes #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change essentially does all the writes needed for creating a VC at the end of the function in one call: |
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 25.06% 24.95% -0.12%
==========================================
Files 31 31
Lines 3036 3050 +14
==========================================
Hits 761 761
- Misses 2158 2172 +14
Partials 117 117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
There is still a case where we can get in trouble. In this case the status list index would be 1 for both VCs (which is wrong) |
decentralgabe
approved these changes
Jan 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Transactional Writes for CreateCredential
Description
This change does changes the way CreateCredential works in that it delays all writes until the end of the function and then transactionally writes them